Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #599

Closed
wants to merge 1 commit into from
Closed

Fix typo #599

wants to merge 1 commit into from

Conversation

DmitrySharabin
Copy link
Member

At the same time, we fix the build process on Netlify.

For now, we have this:

image

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for colorjs failed. Why did it fail? →

Name Link
🔨 Latest commit 9f0283c
🔍 Latest deploy log https://app.netlify.com/sites/colorjs/deploys/66fffa7f09c7a20008317324

@DmitrySharabin
Copy link
Member Author

DmitrySharabin commented Oct 4, 2024

Even with this change, we have the same issue: fetch() fails on the build because we get a URL with a non-supported protocol. Why? We are building the URL using import.meta.url as a base:

const modules = await (await fetch(new URL("data/modules.json", import.meta.url)).json());
In Node, it returns the protocol that fetch() doesn't support.

Even if the site works fine for now, it's because the previous build is being served. All the builds starting from this commit will fail. We will always get this error:

image

@DmitrySharabin
Copy link
Member Author

Since this PR doesn't fix the build on Netlify, I will close it in favor of #600, which fixes both issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants